Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate python 3.7 #1431

Open
technillogue opened this issue Dec 13, 2023 · 6 comments
Open

Deprecate python 3.7 #1431

technillogue opened this issue Dec 13, 2023 · 6 comments

Comments

@technillogue
Copy link
Contributor

technillogue commented Dec 13, 2023

Python 3.7 stopped receiving security support in June. We should release a version of cog that deprecates 3.7 (and supports 3.12), then stop letting people push new 3.7 models. Ideally we should push people to use 3.11 and not just 3.8 so that things get faster.

@technillogue
Copy link
Contributor Author

#1481

@mattt
Copy link
Contributor

mattt commented Feb 22, 2024

Python 3.7 support was previous dropped in #1020, but that was reverted in #1201 after it caused problems for existing models built with 3.7.

@nickstenning Are we in a place now where we could plausibly target newer Python releases?

@nickstenning
Copy link
Member

We can't drop support for Python 3.7 in one go, as we have models running in production that have Python 3.7.

As @technillogue alludes to above, we first need to cut a cog point release that spits out deprecation warnings (likely to the prediction logs to maximise the chance that people see them!), then we need to prevent new models with 3.7 from being pushed.

Depending on the scale of the problem, we may also need to put some banners in people's accounts on the website.

@mattt
Copy link
Contributor

mattt commented Feb 22, 2024

Is the problem that models running Python 3.7 will fail when we try to install the latest version of Cog at startup? If so, could we skip that step? Or else change the logic to install the latest 3.7 compatible version?

@nickstenning
Copy link
Member

The entire cluster runs the same version of Cog. I don't think we want to change that right now.

@technillogue
Copy link
Contributor Author

the shortest-term change is to just stop letting people push new models with 3.7. adding deprecation warnings in prediction logs sounds great. after a few months it's entirely possible we will no longer be breaking anything important that's still being used

dkhokhlov added a commit that referenced this issue Feb 25, 2024
Ref: #1431

Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
dkhokhlov added a commit that referenced this issue Feb 25, 2024
Ref: #1431

Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
dkhokhlov added a commit that referenced this issue Feb 25, 2024
Ref: #1431

Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
dkhokhlov added a commit that referenced this issue Feb 26, 2024
Ref: #1431

Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants