-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate python 3.7 #1431
Comments
Python 3.7 support was previous dropped in #1020, but that was reverted in #1201 after it caused problems for existing models built with 3.7. @nickstenning Are we in a place now where we could plausibly target newer Python releases? |
We can't drop support for Python 3.7 in one go, as we have models running in production that have Python 3.7. As @technillogue alludes to above, we first need to cut a cog point release that spits out deprecation warnings (likely to the prediction logs to maximise the chance that people see them!), then we need to prevent new models with 3.7 from being pushed. Depending on the scale of the problem, we may also need to put some banners in people's accounts on the website. |
Is the problem that models running Python 3.7 will fail when we try to install the latest version of Cog at startup? If so, could we skip that step? Or else change the logic to install the latest 3.7 compatible version? |
The entire cluster runs the same version of Cog. I don't think we want to change that right now. |
the shortest-term change is to just stop letting people push new models with 3.7. adding deprecation warnings in prediction logs sounds great. after a few months it's entirely possible we will no longer be breaking anything important that's still being used |
Ref: #1431 Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
Ref: #1431 Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
Ref: #1431 Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
Ref: #1431 Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
Python 3.7 stopped receiving security support in June. We should release a version of cog that deprecates 3.7 (and supports 3.12), then stop letting people push new 3.7 models. Ideally we should push people to use 3.11 and not just 3.8 so that things get faster.
The text was updated successfully, but these errors were encountered: