Throw error if user tries to upload the same version twice #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are real! |
|
Looks good otherwise! Not important because it seems unlikely, but I don't think handles the case where two pushes happen simultaneously. Maybe it will just silently get overwritten with the one that gets written last, which seems reasonable, but this will cause two webhooks to get sent for the same ID which will throw an error. |
andreasjansson
force-pushed
the
andreas/handle-repush
branch
2 times, most recently
from
16ed7fd
to
3234f44
Compare
Signed-off-by: andreasjansson <andreas@replicate.ai>
andreasjansson
force-pushed
the
andreas/handle-repush
branch
from
3234f44
to
7797a2e
Compare
Yeah I think we can live with that for now at least. Fixed tests. |
|
✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: andreasjansson andreas@replicate.ai
Closes #73