Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for 'HEALTHCHECK' command #117

Merged
merged 4 commits into from
Aug 10, 2020
Merged

Add check for 'HEALTHCHECK' command #117

merged 4 commits into from
Aug 10, 2020

Conversation

egoexpress
Copy link
Contributor

This PR adds support for the HEALTHCHECK command. It adds the following checks:

  • allow HEALTHCHECK as valid Dockerfile command
  • check that HEALTHCHECK NONE doesn't have any additional arguments
  • check that the options for HEALTHCHECK [options] CMD are allowed according to the docs

@boly38 boly38 mentioned this pull request Oct 3, 2019
Closed
@boly38
Copy link

boly38 commented Oct 3, 2019

this PR will fix #28

boly38
boly38 approved these changes Oct 3, 2019
View reviewed changes
Copy link

@boly38 boly38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boly38 boly38 mentioned this pull request Oct 3, 2019
Closed
@marccampbell marccampbell merged commit b31ff16 into replicatedhq:master Aug 10, 2020
@kumy kumy mentioned this pull request Aug 10, 2020
Merged
@jokay jokay mentioned this pull request Jan 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boly38 boly38 boly38 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egoexpress @boly38 @marccampbell