This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
release ship even if the go.mod/go.sum files have changed #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
reviewed
Mar 16, 2020
.circleci/config.yml
Outdated
| @@ -602,6 +602,11 @@ jobs: | |||
| - run: docker pull alpine:latest # make sure it's fresh | |||
| - deploy: | |||
| command: | | |||
| git diff go.mod | |||
| git update-index --assume-unchanged go.mod | |||
There was a problem hiding this comment.
why does this need to be in the ci? seems like a potential security issue
There was a problem hiding this comment.
I'll update this with a 'run git diff before release' version (instead of ignoring those changes)
emosbaugh
approved these changes
Mar 16, 2020
| @@ -602,6 +602,8 @@ jobs: | |||
| - run: docker pull alpine:latest # make sure it's fresh | |||
| - deploy: | |||
| command: | | |||
| git diff | |||
There was a problem hiding this comment.
so that we can tell why the release failed
if it fails due to "there's a change somewhere in your git repo" like last time
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Fixed the issue that prevented tag v0.53.0 from releasing, by ignoring it
How I Did it
How to verify it
Description for the Changelog
Picture of a Ship (not required but encouraged)