add http collector timeouts; fixes #1064

[arcolife]

Description, Motivation and Context

add http collector timeouts

Fixes #1064

Checklist

• New and existing tests pass locally with introduced changes.
• Tests for the changes have been added (for bug fixes / features)
• The commit message(s) are informative and highlight any breaking changes
• Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

• Yes
• No

adds the feature for both v1beta1 and v1beta2

[CLAassistant]

All committers have signed the CLA.

[banjoh]

Your changes LGTM. I added one comment to address an improvement to some of the old code

I suggest we add some tests here. There are no tests for this collector unfortunately, so its a start from scratch

[banjoh]

Probably on your radar already, either way, remember to create a PR with the docs change.

The collector parameters do not mention the HTTP methods (again, legacy issue). I suggest we add this to the docs as we add this new parameter so that the documentation represents such a hierachy

get|post|put - http method used to make the request
   - url: ....
   - insecureVerify: ....
   - ...

I did something like this replicatedhq/troubleshoot.sh#522

[banjoh]

I did something like this replicatedhq/troubleshoot.sh#522

My change led to the docs looking like https://troubleshoot.sh/docs/collect/custom-metrics/#parameters

[arcolife]

@banjoh I'll make the changes as per our discussions but really would've written it like this:

collectors:
    - http:
        collectorName: healthz
        url: https://example.com/
        method: get
        headers: ...

..for these purposes:

• Avoid unnecessary nested levels thereby reducing chances of indentation errors
• Removes the ambiguity while specifying multiple methods.
• And we don't have to specify any special lint instructions in the doc.

Not sure what this breaks though (support bundle analysis, breaking changes in customer envs etc), so I wouldn't do it right away.

[banjoh]

Not sure what this breaks though (support bundle analysis, breaking changes in customer envs etc), so I wouldn't do it right away.

Agreed. It would look cleaner this way but the migration effort to adopt this outweighs the benefits IMHO