-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start build tool migration and improve test running #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue of emojis (and other higher unicode plane glyphs) not being transformed into utf-8 correctly, and hence giving the wrong hash. For existing users, there is a backwards compatibility escape hatch `*use-legacy-utf8-conversion*` that can be set to revert to the old algorithm in case any of those hashes have been stored without the ability to rehash. The new approach works for any modern version of cljs, but if you use google closure < 2016 it has this bug: google/closure-library#470 . It's not obvious, but it looks fixed as of Dec 2, 2015.
Fix UTF-8 conversion in cljs
Add kaocha Add shadow-cljs Clean up dead code Update .gitignore
groundedsage
changed the title
Start build-tool migration and improve test running
Start build tool migration and improve test running
Aug 31, 2020
whilo
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.