Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start build tool migration and improve test running #14

Merged
merged 12 commits into from
Sep 23, 2020
Merged

Start build tool migration and improve test running #14

merged 12 commits into from
Sep 23, 2020

Conversation

groundedsage
Copy link
Member

No description provided.

mikekap and others added 8 commits August 6, 2020 17:58
This fixes the issue of emojis (and other higher unicode plane glyphs) not being transformed into utf-8 correctly, and hence giving the wrong hash.
For existing users, there is a backwards compatibility escape hatch `*use-legacy-utf8-conversion*` that can be set to revert to the old algorithm
in case any of those hashes have been stored without the ability to rehash.

The new approach works for any modern version of cljs, but if you use google closure < 2016 it has this bug: google/closure-library#470 . It's not obvious, but it looks fixed as of Dec 2, 2015.
Fix UTF-8 conversion in cljs
Add kaocha
Add shadow-cljs
Clean up dead code
Update .gitignore
@groundedsage groundedsage changed the title Start build-tool migration and improve test running Start build tool migration and improve test running Aug 31, 2020
@TimoKramer TimoKramer changed the base branch from develop to development September 22, 2020 22:10
Copy link
Member

@whilo whilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@whilo whilo merged commit f840ece into replikativ:development Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants