Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent nodejs names versions #365

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Consistent nodejs names versions #365

merged 3 commits into from
Jun 27, 2024

Conversation

airportyh
Copy link
Collaborator

Why

Inconsistent Node.js and related module names and display versions:

image

What changed

  1. Removed the version number from the name for all cases, so it's not duplicated with the display version
  2. Moved vue-node-18 out of historical and into active. Fewer historical modules the better, I think.

Test plan

That list should look a lot cleaner.

@airportyh airportyh marked this pull request as ready for review June 27, 2024 17:55
@airportyh airportyh requested a review from a team as a code owner June 27, 2024 17:55
@airportyh airportyh requested review from ryantm and removed request for a team June 27, 2024 17:55
ryantm
ryantm approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@airportyh airportyh merged commit 5a64b7f into main Jun 27, 2024
1 check passed
@airportyh airportyh deleted the th-consistent-nodejs-names-versions branch June 27, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airportyh @ryantm