simplify proxy, move seq check to no session path #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
requested review from
Monkatraz,
lhchavez and
masad-frost
and removed request for
a team
lhchavez
reviewed
Jul 12, 2024
lhchavez
approved these changes
Jul 12, 2024
| expect(oldClientSessionId).not.toBeUndefined(); | ||
| expect(oldServerSessionId).not.toBeUndefined(); | ||
|
|
||
| await advanceFakeTimersBySessionGrace(); |
There was a problem hiding this comment.
request: we should also try a reconnect here (that was the OG bug)
There was a problem hiding this comment.
other test "reconnecting before grace period ends should leave session intact" should cover this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What changed
elsecheck in the server so that we properly checkclientNextSentSeq > 0 || clientNextExpectedSeq > 0even if we just went through a hard reconnectVersioning