Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfg.Project can be nil, which panics #288

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

blast-hardcheese
Copy link
Collaborator

Why

Surely there must be a way to statically analyze this.

What changed

Turns out cfg.Project was being accessed without nil check.

Test plan

Manual testing

@blast-hardcheese blast-hardcheese added the bug Something isn't working label Sep 6, 2024
@blast-hardcheese blast-hardcheese requested a review from a team as a code owner September 6, 2024 23:36
@blast-hardcheese blast-hardcheese requested review from ryantm and removed request for a team September 6, 2024 23:36
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) September 6, 2024 23:36
@blast-hardcheese blast-hardcheese merged commit 7a4171a into main Sep 6, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/uv-backend-panic branch September 6, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants