Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stutter fix #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Stutter fix #19

wants to merge 3 commits into from

Conversation

MFarejowicz
Copy link
Contributor

Fix an issue in the Resize component where the user continuously dragging would cause the component to start to stutter (appear and disappear in quick succession).

@sanjaypojo
(Also I started this branch before Nancy's most recent PR was merged, so I pulled her changes into this, but I'm not sure why it's showing some of my commits twice. Do you know why that is?)

@MFarejowicz
Copy link
Contributor Author

@sanjaypojo
Commits now look much cleaner.
Also I attempted removing the array but the issue persisted with this approach, so I believe it is not a scope issue. The way it is supposed to work is that when initially resized, the component should be gone for at least 1.2 seconds, and this timer is refreshed whenever the resizing continues. With the old approach, the timer wasn't properly refreshed, so the stutter would begin after 1.2 seconds. Using an array keeps track of all the function calls and makes sure it is refreshed properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant