Loading #5
Merged
Loading #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also as a side note, since we now have multiple things offered in replot-core (Tooltip, Resize, LoadingIcon), you can see that I changed index.jsx to export all of them wrapped in a object. This means that when users use something from core, they will also have to specify |
|
@MFarejowicz, yup that's the ideal way to export IMO! And awesome work, ran it in my browser, looks great 💯 Merging this in now! @lnancy could you take a look at this later to see what is a good default spacing + color combination. You can just give me a separate pull request with that, should be a very minor change. |
sanjaypojo
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @sanjaypojo I went ahead and completed work on the LoadingIcon component. Would appreciate a quick look at the code, or a read through the README to see if it's what you were looking for. Currently you can specify a width as well as a fill for the component. If you'd like to see it in action, feel free to run example_loading.html!
If it looks good, go ahead and merge this in!