Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add initial implementation of RepoBee 4 review commands #868

Merged
merged 11 commits into from
Mar 13, 2021

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Mar 13, 2021

#867

This is an initial, and pretty shaky, implementation of the RepoBee 4 review commands. If the environment variable REPOBEE_4_REVIEW_COMMANDS is set to true, then these new review commands replace the existing ones. So, in a "normal" setup, the new review commands are invisible. This PR also introduces some neat infrastructure for handling feature flags.

Given that the environment variable is set appropriately, the following applies:

  • reviews assign is unchanged in terms of usage, but it now spits out a review_allocations.json file.
  • reviews check takes only two arguments (in addition to the base arguments): --allocations-file and --title-regex
    • --allocations-file takes the provided allocations file.
    • --title-regex works as before, and will very likely be removed altogether in future iterations.
  • reviews end only takes the --allocations-file argument (in addition to base arguments)

This is just the first draft of this functionality. Group reviews don't work properly, and there may be some kinks with double-blind as well. The details will change, but this represents the general idea of the simplification of the interface.

@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #868 (0540707) into master (672532e) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   90.60%   90.79%   +0.18%     
==========================================
  Files          70       71       +1     
  Lines        3726     3779      +53     
  Branches      546      556      +10     
==========================================
+ Hits         3376     3431      +55     
+ Misses        281      280       -1     
+ Partials       69       68       -1     
Impacted Files Coverage Δ
src/_repobee/cli/dispatch.py 87.91% <100.00%> (+0.55%) ⬆️
src/_repobee/cli/mainparser.py 100.00% <100.00%> (ø)
src/_repobee/command/peer.py 96.71% <100.00%> (+0.67%) ⬆️
src/_repobee/featflags.py 100.00% <100.00%> (ø)
src/repobee_plug/config.py 89.36% <0.00%> (+0.72%) ⬆️
src/_repobee/cli/argparse_ext.py 92.98% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672532e...0540707. Read the comment docs.

@slarse slarse merged commit 8b0bcd2 into repobee:master Mar 13, 2021
@slarse slarse deleted the issue/867-add-preview-review-commands branch March 13, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant