-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry POSTing logs if KeyError occurs on iterating over env variables #40
Conversation
59403ce
to
788af64
Compare
reportportal_client/service.py
Outdated
verify=self.verify_ssl | ||
) | ||
except KeyError: | ||
if i < 9: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9
- Looks like "magic" number. Let's create module level variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove magic number.
@rplevka up |
788af64
to
0a3e6fa
Compare
@krasoffski @DzmitryHumianiuk - comments addressed. |
@krasoffski good to merge? |
…iterating over env variables
0a3e6fa
to
3abebb0
Compare
addresses #39
Add a simple retry loop to catch intermittent race condition occurring when py.test unsets
PYTEST_CURRENT_TEST
variable duringurllib
's iterating over env. variables