-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1661] Upgrade to Gradle 7 #1780
[#1661] Upgrade to Gradle 7 #1780
Conversation
The Liferay plugin has recently been updated with annotations for Gradle 7. As Gradle 7 is now available for use, this also means that the Shadow plugin can be updated to the latest version. There are some deprecated features that will be removed in a future Gradle 8 release. These include an implicit dependency between processResources and zipReport and the change from Report.enabled to Report.required. The processSystemtestResources task fails because Gradle 7 requires a duplicatesStrategy to be defined for the task, which is of the Copy type. Let's upgrade to Gradle 7, update the relevant plugins and fix the duplicatesStrategy error as well as deprecations related to Gradle 8.
Gradle 7.4.2 supports all JDK versions from 8 to 17. However, Java 18 is not yet supported. Let's update the DG prerequisite for JDK version.
c9ed154
to
fed74f2
Compare
@yhtMinceraft1010X Does |
I tried running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job, especially with the issue created upstream and the pull request you have submitted.
The following links are for previewing this pull request:
|
Fixes #1661
Proposed commit message
Other information
Discussion about
duplicatesStrategy
: gradle/gradle#17236