[#1661] Upgrade to Gradle 7 #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Liferay plugin has recently been updated with annotations for Gradle 7. As Gradle 7 is now available for use, this also means that the Shadow plugin can be updated to the latest version. There are some deprecated features that will be removed in a future Gradle 8 release. These include an implicit dependency between processResources and zipReport and the change from Report.enabled to Report.required. The processSystemtestResources task fails because Gradle 7 requires a duplicatesStrategy to be defined for the task, which is of the Copy type. Let's upgrade to Gradle 7, update the relevant plugins and fix the duplicatesStrategy error as well as deprecations related to Gradle 8.
Gradle 7.4.2 supports all JDK versions from 8 to 17. However, Java 18 is not yet supported. Let's update the DG prerequisite for JDK version.
yhtMinceraft1010X
force-pushed
the
1661-upgrade-gradle
branch
from
c9ed154
to
fed74f2
Compare
|
@yhtMinceraft1010X Does |
|
I tried running |
dcshzj
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
LGTM! Great job, especially with the issue created upstream and the pull request you have submitted.
|
The following links are for previewing this pull request:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1661
Proposed commit message
Other information
Discussion about
duplicatesStrategy: gradle/gradle#17236