-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor/styleguide get rid of deprecated apis) refactor(styleguide): get rid of APIs that are to be removed in React 19 + convert JS to TS #841
Open
trm217
wants to merge
19
commits into
main
Choose a base branch
from
refactor/styleguide-get-rid-of-deprecated-apis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trm217
commented
May 17, 2024
- chore(styleguide): use 'tsup' instead of 'tsc' to compile styleguide
- fix(styleguide): custom-types.ts -> custom-types.d.ts + fix faulty types
- fix(styleguide): update package.json's exports key
- fix(publikator): faulty usage of 'colors' object
- refactor(styleguide): start replacing defaultProps with defaultAssignment + propTypes with type-declarations
- refactor(styleguide/components/dossier): convert to TS and get rid off deprecated APIs
- refactor(styleguide/components/CommentBody): convert to TS and get rid off deprecated APIs
- refactor(styleguide/components): convert to TS and get rid off deprecated APIs
- refactor(styleguide): bulk convert files to TS and get rid off deprecated APIs
trm217
force-pushed
the
refactor/styleguide-get-rid-of-deprecated-apis
branch
from
May 17, 2024 16:17
4bcb882
to
10aee72
Compare
trm217
force-pushed
the
refactor/styleguide-get-rid-of-deprecated-apis
branch
from
May 22, 2024 09:32
db44651
to
23ad09a
Compare
…is not being run in watch-mode
…ment + propTypes with type-declarations
…f deprecated APIs
trm217
force-pushed
the
refactor/styleguide-get-rid-of-deprecated-apis
branch
from
May 30, 2024 10:51
23ad09a
to
2d234fb
Compare
…ated APIs refactor(styleguide/components/CommentBody): convert to TS and get rid off deprecated APIs
trm217
force-pushed
the
refactor/styleguide-get-rid-of-deprecated-apis
branch
from
May 30, 2024 12:50
2d234fb
to
d4fd192
Compare
jstcki
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.