-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive Plantuml with searchable content #2751
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge latest with fork
Syncing with latest wikijs to keep fork in sync
Syncing fork to upstream
merge latest
Closing this pull request - will squash the commits to make it more readable and open a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of the original pull request here
Creating this pull request on dev branch as discussed with @NGPixel
Summary:
Plantuml is currently created as an image which means that links donot work and content is treated as a picture.
This PR does the following:
object
tag so that it is interactive and selectable (e.g. you can now copy paste text from within the diagramAs
object
is typically insecure, it will go through the following checks and sanitisation before being keptdata
attribute must start with the URL/sub domain of preconfigured plantuml server and image type (e.g. svg) in wikijs config (e.g. https://plantuml.requarks.io/svg)data
are reset to required values for plantuml processingTested using sample markdown