fix: don't push files to git if ignored #5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Just one small change, rename variable |
Completed |
NGPixel
approved these changes
May 27, 2022
NGPixel
pushed a commit
that referenced
this pull request
Jun 17, 2022
* fix: don't push files to git if ignored * tweak: change gitPath var to gitFilePath * fix: "update" instead of "create" of updated file Co-authored-by: Jacob Parker <blocckba5her@gmail.com> Co-authored-by: DevBlocky <16978528+DevBlocky@users.noreply.github.com>
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
* fix: don't push files to git if ignored * tweak: change gitPath var to gitFilePath * fix: "update" instead of "create" of updated file Co-authored-by: Jacob Parker <blocckba5her@gmail.com> Co-authored-by: DevBlocky <16978528+DevBlocky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an edge case we ran into wanting to keep internal documentation off our synced git storage. This change allows us to maintain our own gitignore file to exclude files from git storage and still sync them to other storage backends.