-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New admin setting to redirect unauthorized guests to login provider #6335
base: main
Are you sure you want to change the base?
Conversation
That's not what |
Since leaving them in the v-switch without values breaks the switch.
Thanks @NGPixel, your comment makes complete sense. The above commits add a new admin switch to enable this functionality (as you suggested). However, there's currently no label or hint in the v-switch (I've moved and commented them out) because without those properties present in the localization config the switch doesn't work (but it does work with them moved out of the way). I've also submitted a PR to the localization project to add the suggested label and hint properties. Thanks! |
Hello! Just checking in on this -- let me know if there's anything I can do to help with the review. Thanks! |
FYI this sounds very like a PR I put in a couple of years back #3786 which was never approved.. if this is approved then that PR should be closed/rejected |
When the administrator has chosen to bypass the login screen, this change will take an unauthorized guest user to the login provider for any link, not just the home page. This should provide a solution for several feedback items, such as:
https://feedback.js.wiki/wiki/p/bypass-login-screen-option-should-apply-to-deep-links (mine! 😄)
https://feedback.js.wiki/wiki/p/login-auto-redirect
https://feedback.js.wiki/wiki/p/skip-unauthorized-screen-for-private-wikis
Steps to recreate (in a dev instance):
/subpage
as a secondary page (in addition to the homepage)/subpage
-- it should send you to the login screen instead of returning an 'Unauthorized' error.If there's a different way you'd prefer this implemented, I'm happy to help!