Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsable Regions and Pasting Images #6551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmc6297
Copy link
Contributor

@dmc6297 dmc6297 commented Jul 3, 2023

  1. Create a collapsable region
<markdown collapsable title="my image.png" type="Image">
</markdown>
  1. Allow pasting of images. Converted to base64 and embedded into markdown as <img>

@auto-assign auto-assign bot requested a review from NGPixel July 3, 2023 23:18
@dmc6297 dmc6297 changed the title Paste Images Collapsable Regions and Pasting Images Jul 3, 2023
@R0Wi
Copy link

R0Wi commented Aug 6, 2023

I tested this feature and it works great, thank you @dmc6297 !

Screencast.mp4

Maybe the code in the area of https://github.com/requarks/wiki/pull/6551/files#diff-6572222f98358241abe369388929bd7692fc070e1ef397ec605ee31f83f984d0R684 could be refactored a little bit for better readability. But from a functional point of view this is exactly what people need in #5441. Hope some of the maintainers will find some time soon to review this 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants