Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hardcode strings in "Pages" to i18n keys #6738

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

solynkaz
Copy link

@solynkaz solynkaz commented Sep 22, 2023

Changed all hard coded strings in "Pages", "Page Details" and "Visualize".
Is there any way to get access to Wiki JS localization database, to contribute keys?
If so, I would complete changing all hard coded strings on whole project and will contribute on translation in lokalise as Russian translator.
Or if there's another way to help with translation in current 2.x version, please, let me know.

Copy link

@quintushr quintushr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the changes, and everything looks good to me. The addition of translation support for the label and hint of the feature switch is a valuable enhancement.

Thanks for your contribution to the project!

Best regards,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added translation support for the label and hint of the features switch, enhancing the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants