Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Elasticsearch 8.x support #6904

Merged
merged 11 commits into from
Oct 12, 2024

Conversation

jacobacon
Copy link
Contributor

@jacobacon jacobacon commented Dec 25, 2023

Modify ElasticSearch search module to support v8.x.

Changes:

  • Added 8.x to enum in definition.yml
  • Add ElasticSearch 8.x client to dependencies
  • Remove 6.x specific _doc mapping definitions in engine.js
  • Add 8.x specific mappings
  • Modify logic to handle differences between 6.x 7.x / 8.x client responses.

6.x is EOL and no longer supported by ElasticSearch; Some of the logic can be further simplified if support for 6.x is dropped.

Tests:
I've tested fairly extensively with 8.x creating, deleting and renaming pages to validate indices are created. I have not done any regression testing against 6.x or 7.x ElasticSearch.

@jacobacon jacobacon marked this pull request as ready for review December 26, 2023 20:38
@auto-assign auto-assign bot requested a review from NGPixel December 26, 2023 20:38
@skjoedt
Copy link

skjoedt commented Mar 18, 2024

What is missing for this to land in main?

@jacobacon
Copy link
Contributor Author

What is missing for this to land in main?

Code wise should be complete now. I've tested with ES 7.x, and 8.x and all features seem to be working as expected. I don't have a 6.x cluster setup, so I wasn't able to test.

@NGPixel, I modified the code to keep the type field for 6.x and 7.x, and merged in upstream changes. Can you review?

@xlammertink
Copy link

Hi all, it seems that Wiki.JS is not supporting ElasticSearch version 8 yet, while this version has been around since 2021. Looking at this PR it seems that everything is in place to introduce the support of ElasticSearch 8. @NGPixel Could you review this PR?

@NGPixel NGPixel merged commit 7757de3 into requarks:main Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants