-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Elasticsearch 8.x support #6904
Conversation
What is missing for this to land in main? |
Code wise should be complete now. I've tested with ES 7.x, and 8.x and all features seem to be working as expected. I don't have a 6.x cluster setup, so I wasn't able to test. @NGPixel, I modified the code to keep the type field for 6.x and 7.x, and merged in upstream changes. Can you review? |
Hi all, it seems that Wiki.JS is not supporting ElasticSearch version 8 yet, while this version has been around since 2021. Looking at this PR it seems that everything is in place to introduce the support of ElasticSearch 8. @NGPixel Could you review this PR? |
Modify ElasticSearch search module to support v8.x.
Changes:
6.x is EOL and no longer supported by ElasticSearch; Some of the logic can be further simplified if support for 6.x is dropped.
Tests:
I've tested fairly extensively with 8.x creating, deleting and renaming pages to validate indices are created. I have not done any regression testing against 6.x or 7.x ElasticSearch.