Update eslintrc file to no longer allow past errors #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good to me. created #1163 for Travis failure. I'll merge this tomorrow if no one objects or beats me to it. |
|
👍 |
nylen
added a commit
that referenced
this pull request
Oct 14, 2014
Update eslintrc file to no longer allow past errors
nylen
added a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
…ve-warning Update eslintrc file to no longer allow past errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@emkay @nylen @mikeal Does this new rule list work? I'm not sure where we ended up re: #1156 and one-line if-statements, but it sounds like it's not possible to allow only those