Avoid useless Buffer transformation #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I like the |
|
Can I help making this go forward? |
simov
added a commit
that referenced
this pull request
Aug 18, 2015
Avoid useless Buffer transformation
|
Generally we're waiting at least 24 hours before merging a PR. Anyway, do you want me to publish new version on NPM? |
|
Maybe you have another batch of fix to merge. Let's wait tomorrow before publishing to npm. |
|
We are good to make an npm release? |
|
Yep, I was looking at another PR, but I don't feel comfortable merging it yet. Anyway, 2.61 is published on NPM. |
|
Thanks, :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is very naive and aim to solve #1732.
I am not sure about writing tests as I am not fluent with tape. If necessary I can try spend time on it.