-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant code (for Node.js 0.9.4 and below) and dependency #2885
Conversation
May I ask what the status of this PR is? The Hackerone report of |
/cc @simov, perhaps? |
I wanted to make tests green again, first. There was an effort on that front, if you merge master you'll see something like this https://travis-ci.org/request/request/builds/373888724 Besides the warning messages, there is an error with the certificates on node v10:
I've tried generating new certificates numerous times with various options, but it never stopped complaining. @ChALkeR can you help me with that? |
@simov E.g. this works for me in the openssl genrsa 4096 > server.key
openssl req -new -sha256 -key server.key -config server.cnf -out server.csr
openssl x509 -req -sha256 -in server.csr -CA ca.crt -CAkey ca.key -out server.crt Not sure what exactly do you want to test, so better verify that it does what you want it to do. Your |
That one was needed for Node.js 0.9.4 and below, which is not supported anymore.
Hope that helps! I also rebased this PR against current |
🎉 |
It's my fault. |
PR Checklist:
npm test
locally and all tests are passing.PR Description
That code was needed for Node.js 0.9.4 and below, which is not supported anymore.
The tests don't pass, but the exact same tests that fail were already failing on
master
prior to this change./cc @mikeal