editor: add a typeahead component #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-autocomplete
branch
3 times, most recently
from
52297f9
to
6a0c872
Compare
sebdeleze
approved these changes
Aug 17, 2020
Comment on lines
18
to
20
| import { async, ComponentFixture, TestBed } from '@angular/core/testing'; | ||
|
|
||
| import { RemoteTypeaheadComponent } from './remote-typeahead.component'; | ||
| import { RecordModule } from '../../record.module'; | ||
| import { CoreModule } from '../../../core.module'; | ||
| import { HttpClientTestingModule } from '@angular/common/http/testing'; | ||
| import { TranslateModule } from '@ngx-translate/core'; | ||
| import { ReactiveFormsModule } from '@angular/forms'; |
Comment on lines
48
to
51
| get groupField(): string | null { | ||
| const enableGF = this._remoteTypeaheadService.enableGroupField(this._rtOptions); | ||
| return enableGF ? 'group' : null; | ||
| } |
There was a problem hiding this comment.
getter should be placed after ngOn* methods
Comment on lines
18
to
23
| import { TestBed } from '@angular/core/testing'; | ||
|
|
||
| import { RemoteTypeaheadService } from './remote-typeahead.service'; | ||
| import { RecordService } from '../../record.service'; | ||
| import { ApiService } from '../../../api/api.service'; | ||
| import { HttpClientTestingModule } from '@angular/common/http/testing'; |
| if (!query) { | ||
| return of([]); | ||
| } | ||
| const apiQuery = `${options.field}:${query}`; |
There was a problem hiding this comment.
String could be used directly used in getRecords instead of storing it in a const.
jma
force-pushed
the
maj-autocomplete
branch
2 times, most recently
from
2e3f65b
to
08b1596
Compare
jma
force-pushed
the
maj-autocomplete
branch
2 times, most recently
from
2d2994f
to
87b465c
Compare
sebdeleze
approved these changes
Aug 17, 2020
iGormilhit
suggested changes
Aug 18, 2020
Comment on lines
2
to
15
| RERO angular core | ||
| Copyright (C) 2020 RERO | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU Affero General Public License as published by | ||
| the Free Software Foundation, version 3 of the License. | ||
| This program is distributed in the hope that it will be useful, | ||
| but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| GNU Affero General Public License for more details. | ||
| You should have received a copy of the GNU Affero General Public License | ||
| along with this program. If not, see <http://www.gnu.org/licenses/>. |
iGormilhit
added
the
f: editor
iGormilhit
approved these changes
Aug 18, 2020
* Adds a new typeahead component to be able to search a list of suggestion using the backend. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch> Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch> Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the backend.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
How to test?
Code review check list