Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: fix hide/show validation for array #465

Closed
wants to merge 1 commit into from

Conversation

jma
Copy link
Contributor

@jma jma commented Dec 9, 2021

TODO: check if the issue is fixed in ngx-formly and maybe close this PR..

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* Adds a workaround corresponding to a ngx-formly issue:
  ngx-formly/ngx-formly#3083.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-fix-hide-show-array-validation branch from 9848561 to 87ed450 Compare December 9, 2021 08:15
@jma jma marked this pull request as ready for review December 9, 2021 08:16
@jma jma added this to the v1.8.0 milestone Dec 9, 2021
@jma jma closed this Dec 13, 2021
@jma jma deleted the maj-fix-hide-show-array-validation branch December 13, 2021 10:49
@jma jma restored the maj-fix-hide-show-array-validation branch December 13, 2021 10:51
@jma jma reopened this Dec 13, 2021
@jma jma closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants