Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

records: integrate angular UI #77

Merged
merged 1 commit into from
Dec 5, 2019
Merged

records: integrate angular UI #77

merged 1 commit into from
Dec 5, 2019

Conversation

sebdeleze
Copy link
Contributor

@sebdeleze sebdeleze commented Sep 27, 2019

  • Integrates sonar-ui admin angular application.
  • Adds form configuration for editor.
  • Adds addresses for user in fixtures.
  • Adds a "local" option for bootstrap script.
  • Build assets in bootstrap script.
  • Moves fonts to static folder.
  • Removes webpack custom project.
  • Modifies JSON schemas.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze changed the title records: Angular administration records: Angular UI integration Oct 9, 2019
@sebdeleze sebdeleze changed the base branch from master to dev October 9, 2019 09:20
@sebdeleze sebdeleze changed the title records: Angular UI integration records: integrate angular UI Nov 19, 2019
@sebdeleze sebdeleze marked this pull request as ready for review November 19, 2019 15:34
@sebdeleze sebdeleze requested a review from jma November 19, 2019 15:34
@@ -43,6 +43,10 @@ def init_app(self, app):
self.init_config(app)
app.extensions['sonar_app'] = self

if app.config['SONAR_APP_ENABLE_CORS']:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put a comment here to explain why?

Here or in the config.py


with app.test_client() as client:
# Login as user
with client.session_transaction() as sess:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems testing fixtures no?

* Integrates sonar-ui admin angular application.
* Adds editor form configuration for documents, institutions and users.
* Adds addresses for user in fixtures.
* Adds a "local" option for bootstrap script.
* Build assets in bootstrap script.
* Removes webpack custom project.
* Modifies JSON schemas.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit 34c3793 into rero:dev Dec 5, 2019
@sebdeleze sebdeleze deleted the sed-resources-administration branch December 5, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants