Fix wgpu warning due to invalid viewport

We know egui already sets the viewport correctly, so let's not do it redundantly!

Author: Wumpf

crates/re_renderer/src/view_builder.rs

@@ -499,6 +499,11 @@ impl ViewBuilder {
         }
     }
 
+    /// Resolution in pixels as configured on view builder creation.
+    pub fn resolution_in_pixel(&self) -> [u32; 2] {
+        self.setup.resolution_in_pixel
+    }
+
     fn draw_phase<'a>(
         &'a self,
         renderers: &Renderers,
@@ -787,19 +792,9 @@ impl ViewBuilder {
         ctx: &RenderContext,
         render_pipelines: &'a GpuRenderPipelinePoolAccessor<'a>,
         pass: &mut wgpu::RenderPass<'a>,
-        screen_position: glam::Vec2,
     ) {
         re_tracing::profile_function!();
 
-        pass.set_viewport(
-            screen_position.x,
-            screen_position.y,
-            self.setup.resolution_in_pixel[0] as f32,
-            self.setup.resolution_in_pixel[1] as f32,
-            0.0,
-            1.0,
-        );
-
         pass.set_bind_group(0, &self.setup.bind_group_0, &[]);
         self.draw_phase(
             &ctx.read_lock_renderers(),

crates/re_renderer_examples/framework.rs

@@ -294,11 +294,18 @@ impl<E: Example + 'static> Application<E> {
                             );
 
                             for draw_result in &draw_results {
+                                composite_pass.set_viewport(
+                                    draw_result.target_location.x,
+                                    draw_result.target_location.y,
+                                    draw_result.view_builder.resolution_in_pixel()[0] as f32,
+                                    draw_result.view_builder.resolution_in_pixel()[1] as f32,
+                                    0.0,
+                                    1.0,
+                                );
                                 draw_result.view_builder.composite(
                                     &self.re_ctx,
                                     &render_pipelines,
                                     &mut composite_pass,
-                                    draw_result.target_location,
                                 );
                             }
                         };

crates/re_viewer_context/src/gpu_bridge/re_renderer_callback.rs

@@ -78,7 +78,7 @@ impl egui_wgpu::CallbackTrait for ReRendererCallback {
 
     fn paint<'a>(
         &'a self,
-        info: egui::PaintCallbackInfo,
+        _info: egui::PaintCallbackInfo,
         render_pass: &mut wgpu::RenderPass<'a>,
         paint_callback_resources: &'a egui_wgpu::CallbackResources,
     ) {
@@ -97,10 +97,7 @@ impl egui_wgpu::CallbackTrait for ReRendererCallback {
             return;
         };
 
-        let screen_position = (info.viewport.min.to_vec2() * info.pixels_per_point).round();
-        let screen_position = glam::vec2(screen_position.x, screen_position.y);
-
         self.view_builder
-            .composite(ctx, render_pipelines, render_pass, screen_position);
+            .composite(ctx, render_pipelines, render_pass);
     }
 }