Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from Flatbuffers' builtin required attribute #2525

Closed
teh-cmc opened this issue Jun 26, 2023 · 1 comment · Fixed by #2619
Closed

Move away from Flatbuffers' builtin required attribute #2525

teh-cmc opened this issue Jun 26, 2023 · 1 comment · Fixed by #2619
Assignees
@teh-cmc
Labels
codegen/idl

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 26, 2023

First, the required attribute has a bunch of artificial limitations that prevent us from using it in places where it would be very helpful to us (e.g. a scalar in a table). These limitations make sense in the context of Flatbuffers' generated code, but are just an annoyance to us.

Second, the notion of required is very backwards compared to the rest of our stack. Rust & Python expect us to specify whether something is nullable, not whether it is required. Same goes for Arrow.

Move away from the builtin required attribute and introduce our own nullable attribute instead.
@teh-cmc
Copy link
Member Author

teh-cmc commented Jul 6, 2023

Yet another thing that gets very annoying when dealing with unions, let's expedite this.

@teh-cmc teh-cmc self-assigned this Jul 6, 2023
This was referenced Jul 6, 2023
Merged
Closed
@teh-cmc teh-cmc linked a pull request Jul 6, 2023 that will close this issue
Don't use builtin required anymore, introduce nullable instead #2619
Merged
3 tasks
teh-cmc added a commit that referenced this issue Jul 7, 2023
@teh-cmc
Don't use builtin required anymore, introduce nullable instead (#…
670812d 
…2619)

Fixes #2525
Closes #2524

---

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2619) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2619)
- [Docs preview](https://rerun.io/preview/pr%3Acmc%2Fattr_nullable/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fattr_nullable/examples)
@teh-cmc teh-cmc mentioned this issue Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
codegen/idl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use builtin required anymore, introduce nullable instead rerun-io/rerun
1 participant
@teh-cmc