Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid the use of flatbuffers structs altogether in our IDL #2524

Closed
teh-cmc opened this issue Jun 26, 2023 · 2 comments · Fixed by #2619
Closed

Forbid the use of flatbuffers structs altogether in our IDL #2524

teh-cmc opened this issue Jun 26, 2023 · 2 comments · Fixed by #2619
Assignees
@teh-cmc
Labels
codegen/idl

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 26, 2023

Flatbuffers has a struct type, in addition to the more general table, which is just a table with a bunch of extra limitations.

This makes sense in the context of Flatbuffers' generated code as it allows for important optimizations, but doesn't bring much in our case, except confusion, compiler complaints and "more than one way to do things".

We should prevent the use of struct in our IDL, and use table everywhere instead.
@teh-cmc teh-cmc changed the title Forbid the use of flatbuffers structs altogether in our IDL? Forbid the use of flatbuffers structs altogether in our IDL Jun 26, 2023
@teh-cmc teh-cmc mentioned this issue Jun 27, 2023
Closed
@teh-cmc
Copy link
Member Author

teh-cmc commented Jul 6, 2023

Yet another thing that gets very annoying when dealing with unions, let's expedite this.

@teh-cmc teh-cmc mentioned this issue Jul 6, 2023
Merged
3 tasks
@teh-cmc
Copy link
Member Author

teh-cmc commented Jul 6, 2023

With #2525 fixed, this is actually fine as-is.

@teh-cmc teh-cmc linked a pull request Jul 6, 2023 that will close this issue
Don't use builtin required anymore, introduce nullable instead #2619
Merged
3 tasks
@teh-cmc teh-cmc self-assigned this Jul 7, 2023
teh-cmc added a commit that referenced this issue Jul 7, 2023
@teh-cmc
Don't use builtin required anymore, introduce nullable instead (#…
670812d 
…2619)

Fixes #2525
Closes #2524

---

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2619) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2619)
- [Docs preview](https://rerun.io/preview/pr%3Acmc%2Fattr_nullable/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fattr_nullable/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
codegen/idl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use builtin required anymore, introduce nullable instead rerun-io/rerun
1 participant
@teh-cmc