Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing columns on a grid container has no effect #4685

Closed
jleibs opened this issue Jan 4, 2024 · 2 comments · Fixed by #4686
Closed

Editing columns on a grid container has no effect #4685

jleibs opened this issue Jan 4, 2024 · 2 comments · Fixed by #4686
Assignees
@jleibs
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working
Milestone
0.12

Comments

@jleibs
Copy link
Member

jleibs commented Jan 4, 2024

Describe the bug
Trying to change the columns from auto just results in the value sticking with auto.

Appears to be a regression from the blueprint migration.
@jleibs jleibs added 🪳 bug Something isn't working 🟦 blueprint The data that defines our UI labels Jan 4, 2024
@jleibs jleibs added this to the 0.12 milestone Jan 4, 2024
@jleibs
Copy link
Member Author

jleibs commented Jan 4, 2024

Need to figure out how to represent the Auto vs Column information in https://github.com/rerun-io/rerun/blob/main/crates/re_types/definitions/rerun/blueprint/archetypes/container_blueprint.fbs

@emilk is it meaningful to specify the column weights in a context when the layout is auto, or can we just say at unset columns == auto?

@jleibs
Copy link
Member Author

jleibs commented Jan 4, 2024

Answering my own question this is currently something that currently "works" so I'm going to preserve the behavior by explicitly adding a GridColumns component.

@jleibs jleibs mentioned this issue Jan 4, 2024
Merged
4 tasks
@jleibs jleibs self-assigned this Jan 5, 2024
@jleibs jleibs mentioned this issue Jan 5, 2024
Merged
4 tasks
@Wumpf Wumpf mentioned this issue Jan 5, 2024
Closed
jleibs added a commit that referenced this issue Jan 5, 2024
@jleibs
Persist Auto vs Columns for Grid into the Blueprint (#4686)
85350d4 
### What
 - Resolves: #4685

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4686/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4686/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4686/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4686)
- [Docs
preview](https://rerun.io/preview/eeab9f0740e014ab7be07368b97a842eabf0359e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/eeab9f0740e014ab7be07368b97a842eabf0359e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
jleibs added a commit that referenced this issue Jan 5, 2024
@rerun-bot @jleibs
Release 0.12.0-alpha.4 (#4674)
07bd6c7 
### Next steps
- Test the release
- If this is an 'alpha' release, you can just merge the pull request.

Web build:
 - https://app.rerun.io/version/0.12.0-alpha.4/index.html

Python packages:
 - `pip install rerun-sdk==0.12.0a4`

- [ ] Tests
  - [ ] Windows
- [x] Linux (Tested by @jleibs but uncovered several issues during
testing -- check does not indicate ready for release)
    - #4684
    - #4685
    - #4689
  - [ ] MacOS

---------

Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working
Projects
None yet
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

Persist Auto vs Columns for Grid into the Blueprint rerun-io/rerun
1 participant
@jleibs