Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad heuristics for objectron #4689

Closed
jleibs opened this issue Jan 5, 2024 · 3 comments · Fixed by #4874
Closed

Bad heuristics for objectron #4689

jleibs opened this issue Jan 5, 2024 · 3 comments · Fixed by #4874
Labels
📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release

Comments

@jleibs
Copy link
Member

jleibs commented Jan 5, 2024

Describe the bug
The heuristics are now creating a problematic series of space-views in the objectron example.

First there is a 2d "world" view.
Then there is a nested grid container with the expected 3D world view and 2D camera view.

To Reproduce
Go to: https://app.rerun.io/version/0.12.0-alpha.4/index.html

Load the objectron example.

Screenshots
image
@jleibs jleibs added 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release labels Jan 5, 2024
@jleibs jleibs added this to the 0.12 milestone Jan 5, 2024
This was referenced Jan 5, 2024
Closed
Merged
@emilk
Copy link
Member

emilk commented Jan 5, 2024

Hitting the "Re-populate" button on the blueprint fixes it, so it is something wrong with the incremental heuristics.

Running it locally also works correctly, likely because of timing issues (again, incremental heuristics might be a fault).

@Wumpf Wumpf self-assigned this Jan 5, 2024
@Wumpf
Copy link
Member

Wumpf commented Jan 5, 2024

can't repro this from the python script sadly. but that one has another small issue: camera frustum got really small

This was referenced Jan 5, 2024
Merged
Closed
@Wumpf
Copy link
Member

Wumpf commented Jan 5, 2024

We decided to tackle this likely pre-existing issue as part of

@Wumpf Wumpf mentioned this issue Jan 5, 2024
Closed
5 tasks
@Wumpf Wumpf removed this from the 0.12 milestone Jan 5, 2024
jleibs added a commit that referenced this issue Jan 5, 2024
@rerun-bot @jleibs
Release 0.12.0-alpha.4 (#4674)
07bd6c7 
### Next steps
- Test the release
- If this is an 'alpha' release, you can just merge the pull request.

Web build:
 - https://app.rerun.io/version/0.12.0-alpha.4/index.html

Python packages:
 - `pip install rerun-sdk==0.12.0a4`

- [ ] Tests
  - [ ] Windows
- [x] Linux (Tested by @jleibs but uncovered several issues during
testing -- check does not indicate ready for release)
    - #4684
    - #4685
    - #4689
  - [ ] MacOS

---------

Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
@Wumpf Wumpf mentioned this issue Jan 5, 2024
Merged
4 tasks
Wumpf added a commit that referenced this issue Jan 5, 2024
@Wumpf
Workaround for objectron spatial heuristics sometimes failing on star…
45f084e 
…tup (#4707)

### What

Workaround for:
* #4689

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4707/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4707/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4707/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4707)
- [Docs
preview](https://rerun.io/preview/7e5c1a8ac5d3ad4cb5c5209faf9fd98b05d48163/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7e5c1a8ac5d3ad4cb5c5209faf9fd98b05d48163/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Wumpf added a commit that referenced this issue Jan 5, 2024
@Wumpf
Fix 2D images showing up in 3D space views again (#4696)
ffa74a4 
### What

Before: `cargo rerun ./examples/assets` would show 2D images since the
new filter system was actually not fed correctly with
`VisualizableFilterContext3D`

<img width="960" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/9fc4d19d-a8cd-45f0-a121-bd1aac8fe1b8">



Furthermore, we now also mark all 3D objects in 2D space views that
don't have their origin at the pinhole as non-visualizable



Does NOT fix
* #4689


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4696/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4696/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4696/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4696)
- [Docs
preview](https://rerun.io/preview/ca71c481dd8a9261bd51dbc0e79b609fd4d61635/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/ca71c481dd8a9261bd51dbc0e79b609fd4d61635/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf Wumpf removed their assignment Jan 10, 2024
@Wumpf Wumpf mentioned this issue Jan 24, 2024
Merged
4 tasks
Wumpf added a commit that referenced this issue Jan 24, 2024
@Wumpf
objectron should now work without logging workaround
051745f 
See #4689
@Wumpf Wumpf closed this as completed in 15cd60d Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
3 participants
@emilk @Wumpf @jleibs