Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling visibillity on a container doesn't show container contents as hidden in ui #4684

Closed
jleibs opened this issue Jan 4, 2024 · 0 comments · Fixed by #4688
Closed

Toggling visibillity on a container doesn't show container contents as hidden in ui #4684

jleibs opened this issue Jan 4, 2024 · 0 comments · Fixed by #4688
Assignees
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Milestone

Comments

@jleibs
Copy link
Member

jleibs commented Jan 4, 2024

Describe the bug

To Reproduce
Run any example. Toggle the top grid container to be hidden.

Expected behavior
All space views in the container should should as subdued.

Screenshots
image

Expected behavior is similar to hiding a space-view there the contents shows as subdued:
image

Backtrace

Desktop (please complete the following information):

  • OS:

Rerun version

Additional context

@jleibs jleibs added 🪳 bug Something isn't working ui concerns graphical user interface labels Jan 4, 2024
@jleibs jleibs self-assigned this Jan 5, 2024
@jleibs jleibs mentioned this issue Jan 5, 2024
4 tasks
@emilk emilk added this to the 0.12 milestone Jan 5, 2024
emilk pushed a commit that referenced this issue Jan 5, 2024
…#4688)

### What
 - Resolves: #4684
 - Resolves: #4692
 - Resolves: #4693

Also fixes a bug where rare edge-cases of the blueprint would get into
an infinite edit loop.
Added an issue and TODOs to avoid this issue:
 - #4687


![image](https://github.com/rerun-io/rerun/assets/3312232/2e329288-81a9-4ed4-b423-d4fa1dcd07cf)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4688/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4688/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4688/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4688)
- [Docs
preview](https://rerun.io/preview/38c5dd05c23a3ee65e80f2704ec08841c77bd0ef/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/38c5dd05c23a3ee65e80f2704ec08841c77bd0ef/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
jleibs added a commit that referenced this issue Jan 5, 2024
### Next steps
- Test the release
- If this is an 'alpha' release, you can just merge the pull request.

Web build:
 - https://app.rerun.io/version/0.12.0-alpha.4/index.html

Python packages:
 - `pip install rerun-sdk==0.12.0a4`

- [ ] Tests
  - [ ] Windows
- [x] Linux (Tested by @jleibs but uncovered several issues during
testing -- check does not indicate ready for release)
    - #4684
    - #4685
    - #4689
  - [ ] MacOS

---------

Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants