Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Space View options in tab bar #1027

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 1, 2023

I'm also gonna investigate if we can get a button response from the tab button from egui_dock. In that case we should select a space view by clicking its tab name, and we will have no need for the "settings" button.

image

TODO:

  • Add a background to the buttons (in case they cover the tab name)
  • Remove the now unnecessary "headroom" in some views

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk marked this pull request as draft February 1, 2023 12:03
@emilk emilk marked this pull request as ready for review February 1, 2023 12:39
@Wumpf Wumpf self-requested a review February 1, 2023 13:00
@Wumpf
Copy link
Member

Wumpf commented Feb 1, 2023

image
probably too hard atm but would be better if this would go "encoded_input_.." instead of cutting off

crates/re_viewer/src/ui/viewport.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/viewport.rs Outdated Show resolved Hide resolved
emilk and others added 2 commits February 1, 2023 14:36
Co-authored-by: Andreas Reich <andreas@rerun.io>
Co-authored-by: Andreas Reich <andreas@rerun.io>
@emilk
Copy link
Member Author

emilk commented Feb 1, 2023

yes, too hard

@Wumpf
Copy link
Member

Wumpf commented Feb 1, 2023

less self-descriptive code

you make it sound like all code should constantly talk about itself ;D

@emilk emilk merged commit 9b671d5 into main Feb 1, 2023
@emilk emilk deleted the emilk/spaceview-options-in-tab-bar branch February 1, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants