EntityPath::from_str must parse the given string #1114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very dangerous and hard to track footgun:
It is made even more dangerous by the fact that some API will just take the
EntityPath
you give them as-is (e.g.send_path_op
) while some will re-parse it behind the scene (e.g.log_arrow
).Consequently, the following will never work, even though everything looks like it's in the right place:
The event log looks right, except it just doesn't work: