Use different artifact names for wasm/js in debug builds #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Feb 28, 2023
| @@ -51,13 +51,13 @@ set -x | |||
| # that build.rs, which will change the built `.wasm` file while this publish script is running. | |||
| # SUPER BAD! We need to fix this ASAP, but it is the night before our first release public | |||
| # release and I'm tired. Will fix later, mkay? | |||
| echo "MAKE SURE RUST ANALYZER, BACON, CARGO-WATCH etc are all OFF!" | |||
| sudo pkill -9 rust-analyzer bacon cargo cargo-watch | |||
There was a problem hiding this comment.
The warning is still true though given that vscode might respawn analyzer? 🤔
emilk
commented
Feb 28, 2023
emilk
added a commit
that referenced
this pull request
Mar 2, 2023
* Create re_build_web_viewer * Add a re_build_web_viewer binary * Clean up re_build_web_viewer * Clean up the build script * Remove build_web.sh script * Simplify build-script * re_web_server binary: print out where we are hosting * Use different .wasm and .js names for debug builds * Fix * add back warning * Add crate-level docs * Improve docstring * Rename re_web_server to re_web_viewer_server * Rename WebServer to WebViewerServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1327
This PR introduces a new crate
re_build_web_viewerthat replacesbuild_web.sh:cargo r -p re_build_web_viewer -- --debugChecklist