Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same RRD encoding for the SDK comms as for everything else #2065

Merged
merged 2 commits into from
May 9, 2023
Merged

Use the same RRD encoding for the SDK comms as for everything else #2065

merged 2 commits into from
May 9, 2023

Commits on May 9, 2023

  1. Use the same RRD encoding for the SDK comms as for everything else 

    This comes with two benefits:
* We get nice error messages on version mismatch
* We get compression of the TCP stream

There is also a downside: we need to pay for the slow zstd encoding
and decoding.

Closes #2003
    @emilk
    emilk committed May 9, 2023
    Configuration menu
    Copy the full SHA
    c21ae9b View commit details
    Browse the repository at this point in the history

  2. Use let-else to reduce rightward drift

    @emilk
    emilk committed May 9, 2023
    Configuration menu
    Copy the full SHA
    08b0605 View commit details
    Browse the repository at this point in the history