Fix depth precision issues on WebGL due to different NDC space #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused our depth offset based draw order "emulation" to break down on the Web sometimes
Wumpf
added
🪳 bug
teh-cmc
approved these changes
May 16, 2023
1 task
Wumpf
added a commit
that referenced
this pull request
May 22, 2023
…ll 3D scenes (#2170) * Revert "Fix depth precision issues on WebGL due to different NDC space (#2123)" This reverts commit 4f60fd7. * fudge depth offsets on Webgl * hardware_tier global constant, better depth handling for gles * Improve the depth offset for all platforms --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
added a commit
that referenced
this pull request
May 25, 2023
…ll 3D scenes (#2170) * Revert "Fix depth precision issues on WebGL due to different NDC space (#2123)" This reverts commit 4f60fd7. * fudge depth offsets on Webgl * hardware_tier global constant, better depth handling for gles * Improve the depth offset for all platforms --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused our depth offset based draw order "emulation" to break down on the Web sometimes
Details in the code comments!
Compared objectron on web vs native to validate that picking depth still works correctly - luckily we don't blindly assume how our projection matrix is formed anywhere in the code it seems, phew!
Web before:
Web after:
What
Checklist
PR Build Summary: https://build.rerun.io/pr/2123