Fix web depth/projection regression, causing incorrect rendering on all 3D scenes #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🔺 re_renderer
Wumpf
changed the title
Wumpf
force-pushed
the
andreas/web-depth-regression
branch
from
fd6e25c
to
c08c123
Compare
emilk
reviewed
May 19, 2023
Comment on lines
1
to
3
| // True if we're running on Gles/WebGL. | ||
| // (patched accordingly if necessary) | ||
| const GLES = false; |
There was a problem hiding this comment.
I think something like this would be better:
Suggested change
| // True if we're running on Gles/WebGL. | |
| // (patched accordingly if necessary) | |
| const GLES = false; | |
| // True if we're running on Gles/WebGL. | |
| // Will be set by `re_renderer` during startup | |
| const GLES = ${GLES}; |
That way we cannot accidentally break the patch-code without us noticing it.
…or just pass it in the global uniform buffer
Comment on lines
23
to
24
| // On GLES/WebGL, the NDC clipspace range for depth is from -1 to 1 and y is flipped. | ||
| // wgpu/Naga counteracts this by patching all vertex shader with: |
There was a problem hiding this comment.
Suggested change
| // On GLES/WebGL, the NDC clipspace range for depth is from -1 to 1 and y is flipped. | |
| // wgpu/Naga counteracts this by patching all vertex shader with: | |
| // On GLES/WebGL, the NDC clipspace range for depth is from -1 to 1 (and y is flipped). | |
| // wgpu/Naga counteracts this by patching all vertex shaders with: |
| // This is great, since it means that we can pretend depth is 0 to 1 as specified by WebGPU. | ||
| // But it completely messes up depth precision, in particular since we use | ||
| // an inverse depth projection that tries to make use of the high float precision closer to zero. | ||
| eps *= 1000.0; |
There was a problem hiding this comment.
This doesn't seem like an ideal fix. It seems like flipping this around (like the previous PR did) is better for depth precision, just that we also need to flip the Z test?
emilk
force-pushed
the
andreas/web-depth-regression
branch
from
79983a0
to
7fdca02
Compare
emilk
approved these changes
May 22, 2023
emilk
added a commit
that referenced
this pull request
May 25, 2023
…ll 3D scenes (#2170) * Revert "Fix depth precision issues on WebGL due to different NDC space (#2123)" This reverts commit 4f60fd7. * fudge depth offsets on Webgl * hardware_tier global constant, better depth handling for gles * Improve the depth offset for all platforms --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts
and fixes the issue with a generous depth factor instead.
#2123 didn't make sense: The assumption was that depth range is -1 to 1 on the Web, but if that was true all our clipping would have been wrong. In actuality, wgpu emulates 0 to 1 range for us but this causes precision issues.
Fixes #2166
This also improves the z offset on all platforms
Checklist
PR Build Summary: https://build.rerun.io/pr/2170