Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve log_pinhole and support non-RDF pinholes #2614

Merged
merged 67 commits into from
Jul 7, 2023
Merged

Improve log_pinhole and support non-RDF pinholes #2614

merged 67 commits into from
Jul 7, 2023

Commits on Jun 28, 2023

  1. remove somewhat redundant SpaceSpecs

    @Wumpf
    Wumpf committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    81599ef View commit details
    Browse the repository at this point in the history

  2. Camera frustums orient now correctly along view coordinates 

    wip
    @Wumpf
    Wumpf committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a91c502 View commit details
    Browse the repository at this point in the history

  3. don't cache view coordinates on space view state

    @Wumpf
    Wumpf committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    881343b View commit details
    Browse the repository at this point in the history

  4. remove unused unproject_as_ray method

    @Wumpf
    Wumpf committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    eced0ca View commit details
    Browse the repository at this point in the history

  5. fix camera ray and make image coordinate convention more explicit

    @Wumpf
    Wumpf committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    49b3f1e View commit details
    Browse the repository at this point in the history

  6. 3D to 2D hover point projection works now also with weird view coordi… 

    …nates
    @Wumpf
    Wumpf committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    ba27b00 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. use RUB/RDF constants and remove misleading comment about defaults. u… 

    …ndo subtle change in default eye orientation
    @Wumpf
    Wumpf committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    c39606f View commit details
    Browse the repository at this point in the history

  2. add test scene for view coordinates

    @Wumpf
    Wumpf committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    f57a3f5 View commit details
    Browse the repository at this point in the history

  3. fix frustum ray casting not working on left handed coordinate systems

    @Wumpf
    Wumpf committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    228dbbf View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into andreas/fix-frustum-v… 

    …iew-coordinates
    @Wumpf
    Wumpf committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    816b4b2 View commit details
    Browse the repository at this point in the history

  5. add arrows to the pinhole zoo

    @Wumpf
    Wumpf committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    399c6d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Merge branch 'main' into andreas/fix-frustum-view-coordinates

    @emilk
    emilk committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    c52fe59 View commit details
    Browse the repository at this point in the history

  2. Set the correct coordinate system for the camera in the OPF example

    @emilk
    emilk committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    d69c7ce View commit details
    Browse the repository at this point in the history

  3. Import the future in the test

    @emilk
    emilk committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f72a057 View commit details
    Browse the repository at this point in the history

  4. Write out the left-handed coordinates we encounter

    @emilk
    emilk committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    24d6527 View commit details
    Browse the repository at this point in the history

  5. Ignore left-handed coordinate system in test

    @emilk
    emilk committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    6c535f2 View commit details
    Browse the repository at this point in the history

  6. Make sure we lint and format test code

    @emilk
    emilk committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    3d33117 View commit details
    Browse the repository at this point in the history

  7. Link to #1387 in docs

    @emilk
    emilk committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    c1bf004 View commit details
    Browse the repository at this point in the history

  8. Use up= argument for world coordinates

    @emilk
    emilk committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    b8011f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Merge branch 'main' into andreas/fix-frustum-view-coordinates

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    7fd44cf View commit details
    Browse the repository at this point in the history

  2. Inline from_rub_quat

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c80616f View commit details
    Browse the repository at this point in the history

  3. Add camera_xyz=… argument to log_pinhole

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    1e48660 View commit details
    Browse the repository at this point in the history

  4. Only look for the view coordinates on the pinhole entity

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c4bbc10 View commit details
    Browse the repository at this point in the history

  5. Better copy

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4ece9fd View commit details
    Browse the repository at this point in the history

  6. Add docstrings

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    931116e View commit details
    Browse the repository at this point in the history

  7. Improve the documentation

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    119daaf View commit details
    Browse the repository at this point in the history

  8. py-format

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    f84b73f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into andreas/fix-frustum-view-coordinates

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    cca15ad View commit details
    Browse the repository at this point in the history

  10. Test and handle depth cloud projection

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    dadfda8 View commit details
    Browse the repository at this point in the history

  11. py-format and py-lint

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    328a627 View commit details
    Browse the repository at this point in the history

  12. log_pinhole: no need to set matrix, just focal length

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    7735ba8 View commit details
    Browse the repository at this point in the history

  13. Add more sanity checks to test

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    d2bd364 View commit details
    Browse the repository at this point in the history

  14. Better depth image for tests

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    9c62127 View commit details
    Browse the repository at this point in the history

  15. Fix RUB vs RDF in depth cloud shader

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8a7add7 View commit details
    Browse the repository at this point in the history

  16. Handle principal point when painting camera frustum

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    80e73c4 View commit details
    Browse the repository at this point in the history

  17. Better naming: world_from_rub_view

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4ac9358 View commit details
    Browse the repository at this point in the history

  18. py-format

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    26dfb6d View commit details
    Browse the repository at this point in the history

  19. Track down and patch non-finite numbers

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bf797bc View commit details
    Browse the repository at this point in the history

  20. Change back default pinhole to RDF

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a9d38b1 View commit details
    Browse the repository at this point in the history

  21. chmod +x blueprint example

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b76c61f View commit details
    Browse the repository at this point in the history

  22. Merge branch 'main' into emilk/improve-pinhole

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    2bffc47 View commit details
    Browse the repository at this point in the history

  23. chmod +x

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    dea108b View commit details
    Browse the repository at this point in the history

  24. Remove todo

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    959952a View commit details
    Browse the repository at this point in the history

  25. build fix

    @emilk
    emilk committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    e8ef570 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Self-review

    @emilk
    emilk committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    e747e91 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into emilk/improve-pinhole 

    # Conflicts:
#	crates/re_types/source_hash.txt
    @emilk
    emilk committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1ba2063 View commit details
    Browse the repository at this point in the history

  3. Update source_hash.txt goddammit

    @emilk
    emilk committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    48a7ea3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into emilk/improve-pinhole

    @emilk
    emilk authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5fee0c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. improve comment 

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
    @emilk @jleibs
    emilk and jleibs authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    238ab3b View commit details
    Browse the repository at this point in the history

  2. Add warning 

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
    @emilk @jleibs
    emilk and jleibs authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c8ec5d9 View commit details
    Browse the repository at this point in the history

  3. Update source_hash.txt

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    8699522 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into emilk/improve-pinhole

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7177111 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary camera_xyz in rgbd example

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c96de33 View commit details
    Browse the repository at this point in the history

  6. be explicit 

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
    @emilk @jleibs
    emilk and jleibs authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7aece38 View commit details
    Browse the repository at this point in the history

  7. Add try-catch blocks

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    3e2caa6 View commit details
    Browse the repository at this point in the history

  8. py-format

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ff020e7 View commit details
    Browse the repository at this point in the history

  9. Better docstring

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    5f756f8 View commit details
    Browse the repository at this point in the history

  10. Make RDF the default, and add helper for converting between coordinates

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    62fad9c View commit details
    Browse the repository at this point in the history

  11. Even better docstring

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    8cba3af View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into emilk/improve-pinhole

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4cddaa5 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into emilk/improve-pinhole

    @emilk
    emilk authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    280cf1a View commit details
    Browse the repository at this point in the history

  14. Improve docs even more

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2075442 View commit details
    Browse the repository at this point in the history

  15. fix typos

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ac29a55 View commit details
    Browse the repository at this point in the history

  16. FML

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7d2c4e2 View commit details
    Browse the repository at this point in the history

  17. GOD DAMMIT THERE ARE TWO OF THEM

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    309c4c5 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into emilk/improve-pinhole

    @emilk
    emilk authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c65e61e View commit details
    Browse the repository at this point in the history

  19. update source_hash.txt

    @emilk
    emilk committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a1314f7 View commit details
    Browse the repository at this point in the history