-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard input/output support 2: Rust SDK stdout impl/examples/docs #4512
Conversation
52d7156
to
c80d18b
Compare
c2b3750
to
634f7ff
Compare
4d7140a
to
98d62d7
Compare
98d62d7
to
311322e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
Sample works well and is easy to understand
/// | ||
/// `None` indicates stdout. | ||
path: Option<PathBuf>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... you could also have used an enum that makes this more obvious than reinterpreting the meaning of None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, I'd have gone there if it was part of the API but it's just some private field for debugging; not worth it imo.
Add a `stdin` source to the viewer so it can stream data in from standard input. We make `stdin` an explicit input (`rerun -`) like in the good old days, to avoid shady behavior in non-TTY and other esoteric environment (crazy WSL setups, etc). Trust me, it gets quite insane... Checks: - [x] `rerun` works - [x] `rerun -` blocks - [x] `rerun - < data.rrd` works - [x] `cat data.rrd | rerun -` works - [x] `rerun < data.rrd` works but does nothing - [x] `cat data.rrd | rerun` works but does nothing - [x] no-TTY & other esoteric environments don't go completely off the rails --- Part of a small PR series to add stdio streaming support to our Viewer and SDKs: - #4511 - #4512 - #4513 - #4514
0198603
to
0ca0945
Compare
…4514) Allow the C++ SDK to stream RRD data to stdout. Checks: - [x] `just py-build && just cpp-build-examples && echo 'hello from stdin!' | ./build/debug/examples/cpp/stdio/example_stdio | rerun -` --- Part of a small PR series to add stdio streaming support to our Viewer and SDKs: - #4511 - #4512 - #4513 - #4514
Allow the Rust SDK to stream RRD data to stdout.
Checks:
just py-build && echo 'hello from stdin!' | cargo run -p stdio | rerun -
Part of a small PR series to add stdio streaming support to our Viewer and SDKs:
Checklist