Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard input/output support 1: stream RRD data from stdin #4511

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Standard input/output support 1: stream RRD data from stdin #4511

merged 2 commits into from
Dec 14, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Dec 13, 2023 •
edited
Loading

Add a stdin source to the viewer so it can stream data in from standard input.

We make stdin an explicit input (rerun -) like in the good old days, to avoid shady behavior in non-TTY and other esoteric environment (crazy WSL setups, etc). Trust me, it gets quite insane...

Checks:

  • rerun works
  • rerun - blocks
  • rerun - < data.rrd works
  • cat data.rrd | rerun - works
  • rerun < data.rrd works but does nothing
  • cat data.rrd | rerun works but does nothing
  • no-TTY & other esoteric environments don't go completely off the rails

Part of a small PR series to add stdio streaming support to our Viewer and SDKs:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 📺 re_viewer affects re_viewer itself include in changelog CLI Related to the Rerun CLI do-not-merge Do not merge this PR labels Dec 13, 2023
This was referenced Dec 13, 2023
Merged
Merged
Merged
@teh-cmc teh-cmc marked this pull request as ready for review December 13, 2023 19:23
@teh-cmc teh-cmc marked this pull request as draft December 13, 2023 19:31
@teh-cmc teh-cmc force-pushed the cmc/stdio_1_viewer branch 3 times, most recently from ffd439b to c2b3750 Compare December 14, 2023 06:23
teh-cmc
teh-cmc commented Dec 14, 2023
View reviewed changes
Cargo.toml
@@ -101,6 +101,7 @@ array-init = "2.1"
arrow2 = "0.17"
arrow2_convert = "0.5.0"
async-executor = "1.0"
atty = "0.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future truth: used in upcoming PRs.

@teh-cmc teh-cmc marked this pull request as ready for review December 14, 2023 06:35
@Wumpf Wumpf self-assigned this Dec 14, 2023
Wumpf
Wumpf approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking straight forward so far 🤞 😄
(except that line with "-", can almost feel the pain that went into that one)

@Wumpf Wumpf removed their assignment Dec 14, 2023
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Dec 14, 2023
@teh-cmc teh-cmc merged commit 022dcde into main Dec 14, 2023
44 of 49 checks passed
@teh-cmc teh-cmc deleted the cmc/stdio_1_viewer branch December 14, 2023 17:11
teh-cmc added a commit that referenced this pull request Dec 14, 2023
@teh-cmc
Standard input/output support 2: Rust SDK stdout impl/examples/docs (#…
6e49d84 
…4512)

Allow the Rust SDK to stream RRD data to stdout.

Checks:
- [x] `just py-build && echo 'hello from stdin!' | cargo run -p stdio |
rerun -`

---

Part of a small PR series to add stdio streaming support to our Viewer
and SDKs:
- #4511
- #4512 
- #4513
- #4514
teh-cmc added a commit that referenced this pull request Dec 14, 2023
@teh-cmc
Standard input/output support 3: Python SDK stdout impl/examples/docs (…
da466ee 
…#4513)

Allow the Python SDK to stream RRD data to stdout.

Checks:
- [x] `just py-build && echo 'hello from stdin!' | python
examples/python/stdio/main.py | rerun -`

---

Part of a small PR series to add stdio streaming support to our Viewer
and SDKs:
- #4511
- #4512 
- #4513
- #4514
teh-cmc added a commit that referenced this pull request Dec 14, 2023
@teh-cmc
Standard input/output support 4: C++ SDK stdout impl/examples/docs (#…
55beca2 
…4514)

Allow the C++ SDK to stream RRD data to stdout.

Checks:
- [x] `just py-build && just cpp-build-examples && echo 'hello from
stdin!' | ./build/debug/examples/cpp/stdio/example_stdio | rerun -`

---

Part of a small PR series to add stdio streaming support to our Viewer
and SDKs:
- #4511
- #4512 
- #4513
- #4514
@teh-cmc teh-cmc mentioned this pull request Dec 14, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
CLI Related to the Rerun CLI 🧑‍💻 dev experience developer experience (excluding CI) include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf