Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hovering bug introduced in The Great Removal #998

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix hovering bug introduced in The Great Removal #998

merged 1 commit into from
Jan 30, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 30, 2023

Bug introduced by #988

Next up I'll refactor and simplify InstanceId and InstanceIdHash

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk
Fix hovering bug introduced in The Great Removal
630d8cb 
Bug introduced by #988

Next up I'll refactor and simplify `InstanceId` and `InstanceIdHash`
@emilk emilk marked this pull request as ready for review January 30, 2023 19:35
jleibs
jleibs approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some weird code-paths being changed, but looks like they weren't really in use anywhere.

@emilk emilk merged commit 023eb39 into main Jan 30, 2023
@emilk emilk deleted the emilk/fix-object-hover branch January 30, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @jleibs