Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API responses, session/cookie creation, swagger UI #32

Merged
merged 8 commits into from
Feb 3, 2023
Merged

Update API responses, session/cookie creation, swagger UI #32

merged 8 commits into from
Feb 3, 2023

Conversation

kaumnen
Copy link
Contributor

@kaumnen kaumnen commented Feb 3, 2023

No description provided.

@kaumnen kaumnen linked an issue Feb 3, 2023 that may be closed by this pull request
update response upon successful auth endpoint call #28
Closed
@kaumnen
Copy link
Contributor Author

kaumnen commented Feb 3, 2023

Changelog:

  • changed responses upon successful api endpoint call
  • now logout request is DELETE instead of POST
  • user auth endpoints are now grouped under 'User Auth' tag in swagger UI
  • user login now returns 200 with json success
  • added new swagger UI elements for signup and login requests
  • added new response upon failed check for authentication on non-auth requests
  • signup endpoint now does not generate valid session/cookie, only login one

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 3, 2023
View reviewed changes
app.js
sessionConfig.cookie.secure = true;
}

app.use(session(sessionConfig));

Check warning

Code scanning / CodeQL

Clear text transmission of sensitive cookie

Sensitive cookie sent without enforcing SSL encryption.
@kaumnen kaumnen merged commit b14ac15 into main Feb 3, 2023
@kaumnen kaumnen deleted the update_auth_api_response branch February 3, 2023 20:52
@kaumnen kaumnen linked an issue Feb 3, 2023 that may be closed by this pull request
update session set-up only for certain endpoints upon auth #30
Closed
@kaumnen kaumnen mentioned this pull request Feb 3, 2023
Closed
@kaumnen kaumnen linked an issue Feb 3, 2023 that may be closed by this pull request
update swagger endpoints / API Documentation #23
Closed
@kaumnen kaumnen mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kaumnen