Skip to content

fix: js_array and js_array2 wrong return type for from method #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020
+38 −38
Merged

fix: js_array and js_array2 wrong return type for from method #4597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions jscomp/main/builtin_cmi_datasets.ml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion jscomp/others/js_array.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type 'a array_like = 'a Js_array2.array_like
type 'a array_iter = 'a array_like
*)

external from : 'a array_like -> 'b array = "Array.from" [@@bs.val] (* ES2015 *)
external from : 'a array_like -> 'a array = "Array.from" [@@bs.val] (* ES2015 *)
external fromMap : 'a array_like -> ('a -> 'b [@bs.uncurry]) -> 'b array = "Array.from" [@@bs.val] (* ES2015 *)
external isArray : 'a -> bool = "Array.isArray" [@@bs.val] (* ES2015 *)
(* Array.of: seems pointless unless you can bind *) (* ES2015 *)
Expand Down
2 changes: 1 addition & 1 deletion jscomp/others/js_array2.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type 'a array_like
type 'a array_iter = 'a array_like
*)

external from : 'a array_like -> 'b array = "Array.from" [@@bs.val] (* ES2015 *)
external from : 'a array_like -> 'a array = "Array.from" [@@bs.val] (* ES2015 *)
external fromMap : 'a array_like -> ('a -> 'b [@bs.uncurry]) -> 'b array = "Array.from" [@@bs.val] (* ES2015 *)
external isArray : 'a -> bool = "Array.isArray" [@@bs.val] (* ES2015 *)
(* Array.of: seems pointless unless you can bind *) (* ES2015 *)
Expand Down
18 changes: 9 additions & 9 deletions lib/4.06.1/unstable/js_compiler.ml
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions lib/4.06.1/unstable/js_refmt_compiler.ml
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions lib/4.06.1/whole_compiler.ml
View file
Open in desktop

Large diffs are not rendered by default.