Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax: process uncurried function declarations explicitly in the parser/printer #5794

Merged
merged 11 commits into from
Nov 10, 2022
Merged

Syntax: process uncurried function declarations explicitly in the parser/printer #5794

merged 11 commits into from
Nov 10, 2022

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc mentioned this pull request Nov 10, 2022
Closed
2 tasks
@cristianoc cristianoc changed the title process uncurried function declarations explicitly in the parser/printer Syntax: process uncurried function declarations explicitly in the parser/printer Nov 10, 2022
@cristianoc
Update CHANGELOG.md
e3b3229
@cristianoc
Remove example that is not idempotent
6d1bb3a 
This is not idempotent:
let c2 = (. x) => y => x+y
@cristianoc
Copy link
Collaborator Author

This is not idempotent:

let c2 = (. x) => y => x+y

and is in fact one of the examples considered troublesome for uncurried by default.

Up to now it means: uncurried function with 2 arguments.
How does one then represent an uncurried function with 1 argument that returns a curried function? The only way so far is to enclose the body in {...}.

@cristianoc
Interpred arity of uncurried explicitly.
c9b696f 
Interpret the arity of uncurried functions explicitly so this is a unary function:
```
(. x) => y => x+y
```
The parser adds braces to the body to make this explicit.

This is a breaking change. And solves the lack of idempotency in #5794
@cristianoc cristianoc mentioned this pull request Nov 10, 2022
Merged
@cristianoc
Update CHANGELOG.md
8dfd0a0
@cristianoc
Interpred arity of uncurried explicitly.
39e579a 
Interpret the arity of uncurried functions explicitly so this is a unary function:
```
(. x) => y => x+y
```
The parser adds braces to the body to make this explicit.

This is a breaking change. And solves the lack of idempotency in #5794
@cristianoc
Update CHANGELOG.md
890fe81
@cristianoc
snap
8ccb0ea
@cristianoc
Added analogous tests for types.
8aebe38
@cristianoc
Update CHANGELOG.md
02f0cf7
@cristianoc
Merge branch 'braces_on_body' into direct_uncurry_fundef_encoding
3b43bae
@cristianoc cristianoc merged commit 4e9c818 into master Nov 10, 2022
@cristianoc cristianoc deleted the direct_uncurry_fundef_encoding branch November 10, 2022 19:02
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 2, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cristianoc