Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Fix dropping attributes of props in JSX v4 #723

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Fix dropping attributes of props in JSX v4 #723

merged 4 commits into from
Dec 15, 2022

Conversation

mununki
Copy link
Member

@mununki mununki commented Dec 14, 2022

This PR is to backport rescript-lang/rescript#5905

@mununki mununki mentioned this pull request Dec 14, 2022
Merged
cristianoc
cristianoc approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I guess something should be added to the docs or somewhere to expose this functionality.

@mununki mununki mentioned this pull request Dec 15, 2022
Closed
@mununki
Copy link
Member Author

mununki commented Dec 15, 2022

Thank you! I guess something should be added to the docs or somewhere to expose this functionality.

Oh! That's a good idea. I'll add it. rescript-lang/rescript-lang.org#626

@mununki mununki merged commit 3835042 into master Dec 15, 2022
@mununki mununki deleted the jsx-v4-mangle-props-2 branch December 15, 2022 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mununki @cristianoc