This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
JSX4: Fix missing attributes from props type #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mununki
commented
Feb 3, 2023
| getLabel name, | ||
| attrs, | ||
| loc, | ||
| {type_ with ptyp_attributes = optionalAttrs} ) |
There was a problem hiding this comment.
Noted the unnecessary adding of the optional attribute for the core_type.
cristianoc
approved these changes
Feb 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue rescript-lang/rescript#5969
This change keeps the attributes of the argument in the make function and removes the unnecessary optional attr from the core_type as the type parameter. So it prevents that uncurried functions were incorrectly converting the type of a prop given as a default value.
The current master in the compiler transforms the uncurried type annotation correctly without this change, but this change can fix the issue in v10.1.2