support lazy #151
Merged
support lazy #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeddro
commented
Nov 8, 2022
Comment on lines
-459
to
-467
| _binding_pattern: $ => choice( | ||
| $.value_identifier, | ||
| $.tuple_pattern, | ||
| $.record_pattern, | ||
| $.array_pattern, | ||
| $.list_pattern, | ||
| $.module_unpack_pattern, | ||
| $.unit | ||
| ), |
There was a problem hiding this comment.
This rule was introduced in #111 to accept list as a valid variable, but it wasn't really necessary, going back to $._pattern
aspeddro
commented
Nov 8, 2022
Comment on lines
-933
to
-934
| module_unpack_pattern: $ => seq( | ||
| 'module', '(', $.module_identifier, ')', |
There was a problem hiding this comment.
module_unpack_pattern is not needed. module_pack is already listed in $._pattern rule
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #149
Playground