fix(render): Issue with ESM due to dyanmic require
#1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
gabrielmfern
force-pushed
the
fix/esm-issue-with-render
branch
from
b731c20
to
166b2cf
Compare
gabrielmfern
force-pushed
the
fix/esm-issue-with-render
branch
from
989acdc
to
04bbd89
Compare
vcapretz
approved these changes
Jun 6, 2024
gabrielmfern
added a commit
that referenced
this pull request
Jun 6, 2024
gabrielmfern
added a commit
that referenced
this pull request
Jun 25, 2024
gabrielmfern
added a commit
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended for #1486. The issue was that we were using a
requiretodynamically import in the Node
streammodule so that we could read throughreact-dom's stream only when running in Node, and since we wanted for this towork on the browser as well, we compromised into using a dynamic
require.The issue with that was that, in ESM-only builds, this was erroring with stuff like:
The more optimal way of doing what we tried doing there is to have a different
build for the browser and for Node so that we can just import and avoid having
to dynamically do so. This PR does exactly that, and it should fix these issues.
It does make it a bit more complicated in the exports section of the
package.jsonthough, so it is something to consider.